Re: [PATCH 1/1] threads_max: Simple lockout prevention patch

From: Al Boldi
Date: Mon Apr 24 2006 - 09:55:54 EST


Pekka Enberg wrote:
> On 4/24/06, Al Boldi <a1426z@xxxxxxxxx> wrote:
> > Like so?
> > if (nr_threads >= max_threads)
> > if (p->pid != su_pid)
> > goto bad_fork_cleanup_count;
>
> It's better to combine the two if statements into one with &&.

I thought of combining them too, but was afraid of some compile optimization
issues. Remember, this code-path is executed for each and every fork in the
system, thus it's highly performance sensitive.

Thanks!

--
Al

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/