Re: [patch 2/4] kref debugging config option

[Greg KH]

On Tue, Apr 25, 2006 at 12:53:37PM +0800, Akinobu Mita wrote:
> On Mon, Apr 24, 2006 at 02:38:45PM -0700, Andrew Morton wrote:
> > Akinobu Mita <mita@xxxxxxxxxxxxxxxx> wrote:
> > >
> > > This patch converts all WARN_ON() in kref code to BUG_ON().
> > 
> > Why?  This change will irritate testers and will decrease their ability to
> > capture (and hence report) diagnostic info.
> 
> I have no grudge against this BUG_ON().
> 
> But BUG_ON() is more prominent than WARN_ON().

Sure, it crashes your kernel, hopefully you notice that better :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/