Re: [PATCH 8 of 13] ipath - fix a number of RC protocol bugs

[Andrew Morton]

"Bryan O'Sullivan" <bos@xxxxxxxxxxxxx> wrote:
>
> +	BUG_ON(qp->timerwait.next != LIST_POISON1);
>  +	list_add_tail(&qp->timerwait, &dev->pending[dev->pending_index]);

Please don't play around with list_head internals like this - some
speedfreak might legitimately choose to remove the list_head poisoning
debug code, or make it Kconfigurable.

One option would be to always do list_del_init() on this thing, then do
BUG_ON(!list_empty()).

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/