Re: [PATCH/RFC] s390: Hypervisor File System

From: Michael Holzheu
Date: Tue Apr 25 2006 - 08:29:27 EST


Pekka Enberg <penberg@xxxxxxxxxxxxxx> wrote on 04/25/2006 09:32:16 AM:
> On Mon, 2006-04-24 at 19:19 +0200, Michael Holzheu wrote:
> > > +#ifndef __HAVE_ARCH_STRRTRIM
> > > +/**
> > > + * strrtrim - Remove trailing characters specified in @reject
> > > + * @s: The string to be searched
> > > + * @reject: The string of letters to avoid
> > > + */
> > > +void strrtrim(char *s, const char *reject)
>
> On Tue, 2006-04-25 at 09:58 +0300, Pekka Enberg wrote:
> > I think this should return s to be consistent with other string API
> > functions.
>
> Hmm, thinking about this, I think a better API would be to not have that
> reject parameter at all. Would something like this be accetable for your
> use?

Yes, strtrip() will work for us! If Andrew takes it, I will use it in my
patch!

Thanks

Michael

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/