Re: question about nfs_execute_read: why do we need to dolock_kernel?

[Trond Myklebust]

On Tue, 2006-04-25 at 10:08 -0400, Xin Zhao wrote:
> Thanks for your reply. So the only reason is for rpc auditing? If so,
> why not just lock the code that updating the audit information? Now
> the code is:

No. You misunderstood me.

I said that we need to audit the _code_ for races.

In the distant past, the rpc code was entirely protected by the BKL
against concurrent access to shared objects (queues, structures,
variables etc). Today, most of those shared objects have been given
their own locks, but nobody has yet gone through the code line by line
in order to check that it is safe to remove the BKL.

Cheers,
 Trond

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/