Re: [patch 3/3] use kref for bio

From: Jens Axboe
Date: Wed Apr 26 2006 - 01:13:04 EST


On Wed, Apr 26 2006, Al Viro wrote:
> On Wed, Apr 26, 2006 at 10:11:02AM +0800, Akinobu Mita wrote:
> > Use kref for reference counter of bio.
> > This patch also removes BUG_ON() for freeing unreferenced bio.
> > But kref can detect it if CONFIG_DEBUG_SLAB is enabled.
>
> *Ugh*
>
> Let's _not_. It's extra overhead for no good reason.

Completely agree. That goes for the other block layer kref patches as
well.

--
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/