Re: [PATCH] likely cleanup: remove unlikely for kfree(NULL)

From: Adrian Bunk
Date: Thu Apr 27 2006 - 04:31:46 EST


On Thu, Apr 27, 2006 at 08:50:40AM +0200, Arjan van de Ven wrote:
> On Thu, 2006-04-27 at 09:28 +0300, Pekka J Enberg wrote:
> > On Thu, 27 Apr 2006, Nick Piggin wrote:
> > > Not to dispute your conclusions or method, but I think doing a
> > > defconfig or your personal config might be more representative
> > > of % size increase of text that will actually be executed. And
> > > that is the expensive type of text.
> >
> > True but I was under the impression that Arjan thought we'd get text
> > savings with GCC 4.1 by making kfree() inline.
>
> not savings in text size, I'll settle for the same size.
>...

It will always be bigger since there are cases where it's unknown at
compile time whether it will be NULL when called.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/