Re: [RFC: 2.6 patch] fs/read_write.c: unexport iov_shorten

[Badari Pulavarty]

On Thu, 2006-04-27 at 20:03 +0200, Adrian Bunk wrote:
> This patch removes the unused EXPORT_SYMBOL(iov_shorten).
> 
> Signed-off-by: Adrian Bunk <bunk@xxxxxxxxx>
> 
> ---
> 
> This patch was already sent on:
> - 23 Apr 2006
> 
> --- linux-2.6.17-rc1-mm3-full/fs/read_write.c.old	2006-04-23 15:51:52.000000000 +0200
> +++ linux-2.6.17-rc1-mm3-full/fs/read_write.c	2006-04-23 15:52:02.000000000 +0200
> @@ -436,8 +436,6 @@
>  	return seg;
>  }
>  
> -EXPORT_SYMBOL(iov_shorten);
> -
>  /* A write operation does a read from user space and vice versa */
>  #define vrfy_dir(type) ((type) == READ ? VERIFY_WRITE : VERIFY_READ)

While you are at it, why not move iov_shorten() to only file its
currently used from filemap.c, make it static and take it out from
uio.h ? (filemap.c may not be the right place for it, but ..)

Thanks,
Badari

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/