checklist (Re: 2.6.17-rc2-mm1)

From: Randy.Dunlap
Date: Thu Apr 27 2006 - 15:42:17 EST



> > So at this point in time what I'd like to do is to encourage developers to
> > do these very basic things. That's the low-hanging fruit right now.
>
> Write a checklist for that?

I've been meaning to write up one myself, so I'll give it a shot.

This is all above and beyond good patch log descriptions.


1. Build cleanly with applicable or modified CONFIG options =y, =m, and =n.
No gcc warnings/errors, no linker warnings/errors.

2. Build on multiple CPU arch-es by using local cross-compile tools
or something like PLM at OSDL.

3. Check cleanly with sparse.

4. Make sure that any new or modified CONFIG options don't muck up
the config menu.

5. Use 'make checkstack' and 'make namespacecheck' and fix any
problems that they find. Note: checkstack does not point out
problems explicitly, but any one function that uses more than
512 bytes on the stack is a candidate for change.

6. Include kernel-doc to document global kernel APIs. (Not required
for static functions, but OK there also.) Use 'make htmldocs'
or 'make mandocs' to check the kernel-doc and fix any issues.


---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/