Re: [PATCH 13/16] ehca: firmware InfiniBand interface

From: Paul Mackerras
Date: Thu Apr 27 2006 - 18:47:02 EST


Jörn Engel writes:

> 25 parameters? If you tell me which drugs were involved in this code,
> I know what to stay away from.

You really need to ask the firmware architects that, since this is
basically a single firmware call.

Mind you, since a lot of the parameters are used to return individual
bytes or half-words, which are then put into structures, it might be
better to pass the pointers to the structures and let the wrapper put
the values straight into the structures.

Paul.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/