Re: [PATCH] x86_64: add nmi_exit to die_nmi

[Andi Kleen]

On Thursday 27 April 2006 19:55, Corey Minyard wrote:
> Playing with NMI watchdog on x86_64, I discovered that it didn't
> do what I expected.  It always panic-ed, even when it didn't
> happen from interrupt context.  

Hmm, I don't think that's true. Or at least it worked at some point.
Ok maybe something regressed.


> This patch solves that 
> problem for me.  Also, in this case, do_exit() will be called
> with interrupts disabled, I believe.  Would it be wise to also
> call local_irq_enable() after nmi_exit()?


Probably yes. I added that with the the patch.

Thanks,
-Andi

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/