Re: [PATCH/RFC] Requested changelog for minix filesystem update to V3

[Jesper Juhl]

On 5/1/06, Willy Tarreau <willy@xxxxxxxxx> wrote:
> Hi Jesper,
>
> just a comment below :
>
> On Mon, May 01, 2006 at 03:06:49PM +0200, Jesper Juhl wrote:
> > On 5/1/06, Daniel Aragonés <danarag@xxxxxxxxx> wrote:
> [snip]
>
> > >-       i = ((numbits-(numblocks-1)*BLOCK_SIZE*8)/16)*2;
> > >+       i = ((numbits-(numblocks-1)*bh->b_size*8)/16)*2;
> >
> > A few more spaces please :
> >
> >  i = ((numbits-(numblocks-1) * bh->b_size * 8) / 16) * 2;
>
> This spacing is still wrong, because I first read it like this :
>
>   i = (((numbits-(numblocks-1)) * bh->b_size * 8) / 16) * 2;
>
> While in fact it's :
>
>   i = ((numbits-((numblocks-1) * bh->b_size * 8)) / 16) * 2;
>
> Strictly speaking, this should be written this way :
>
>   i = ((numbits - (numblocks - 1) * bh->b_size * 8) / 16) * 2;

You are right, I botched that one.


> Or at least :
>
>   i = ((numbits - (numblocks-1) * bh->b_size * 8) / 16) * 2;
>
> Anyway, it's a good sign when only spaces are being discussed on a piece
> of code ;-)
>
> Cheers,
> Willy

--
Jesper Juhl <jesper.juhl@xxxxxxxxx>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/