Re: [PATCH 4a/4] MultiAdmin LSM (LKCS'ed)

[Greg KH]

On Mon, May 01, 2006 at 07:42:33PM +0200, Jan Engelhardt wrote:
> 
> >asm #include goes last.
> 
> How come?

Just the standard style.

> >> +static inline int range_intersect_wrt(uid_t, uid_t, uid_t, uid_t);
> >
> >inline functions don't need definitions like this.
> 
> If memory serves right, callees mentioned below their callers need a 
> prototype.

You can't have a inline function with a prototype :)

> >> +static gid_t Supergid = -1, Subgid = -1;
> >> +static uid_t Superuid_start = 0, Superuid_end = 0,
> >> +    Subuid_start = -1, Subuid_end = -1,
> >> +    Netuid = -1, Wrtuid_start = -1, Wrtuid_end = -1;
> >> +static int Secondary = 0;
> >
> >Variables do not have capital letters.
> 
> Who has, besides macros, if anything?

nothing.

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/