Re: [ALSA] add __devinitdata to all pci_device_id

[Greg KH]

On Tue, May 02, 2006 at 11:48:31AM +0200, Takashi Iwai wrote:
> At Mon, 1 May 2006 09:54:43 -0700,
> Greg KH wrote:
> > 
> > On Mon, May 01, 2006 at 06:49:24PM +0200, Arjan van de Ven wrote:
> > > On Mon, 2006-05-01 at 15:11 +0000, Linux Kernel Mailing List wrote:
> > > > commit 396c9b928d5c24775846a161a8191dcc1ea4971f
> > > > tree 447f4b28c2dd8e0026b96025fb94dbc654d6cade
> > > > parent 71b2ccc3a2fd6c27e3cd9b4239670005978e94ce
> > > > author Henrik Kretzschmar <henne@xxxxxxxxxxxxxxxx> Mon, 24 Apr 2006 15:59:04 +0200
> > > > committer Jaroslav Kysela <perex@xxxxxxx> Thu, 27 Apr 2006 21:10:34 +0200
> > > > 
> > > > [ALSA] add __devinitdata to all pci_device_id
> > > 
> > > 
> > > are you really really sure you want to do this?
> > > These structures are exported via sysfs for example, I would think this
> > > is quite the wrong thing to make go away silently...
> > 
> > I asked Henrik to not do this, but oh well...
> > 
> > No, if they are marked __devinit, and CONFIG_HOTPLUG is enabled, then
> > the sysfs stuff is enabled.  And since CONFIG_HOTPLUG is pretty much
> > always enabled these days, the savings of this kind of patch is
> > non-existant...
> 
> Then actually what could be a pitfall by adding __devinitdata to
> pci_device_id table?  If there is a potential danger, we should remove
> these modifiers from all places, especially from
> Documentation/pci.txt.

There's no real pitfall, only the chance for people to get it wrong
(using __initdata instead, or using __devinitdata for hotplug-only
drivers.)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/