Re: [PATCH 5/13: eCryptfs] Header declarations

From: Artem B. Bityutskiy
Date: Thu May 04 2006 - 11:28:51 EST


Pekka Enberg wrote:
Pekka Enberg wrote:

So, what's wrong with BUG_ON?

I guess because this may be compiled off when no debugging/extra checking is needed.
But you shouldn't write assertions that you don't really need anyway.

I wouldn't be so strict. Normally, you don't need them and disable as they slow you down. But when you are hunting a problem you enable them as they may catch it on an early stage. I don't see anything bad here...

--
Best regards, Artem B. Bityutskiy
Oktet Labs (St. Petersburg), Software Engineer.
+7 812 4286709 (office) +7 911 2449030 (mobile)
E-mail: dedekind@xxxxxxxxxxxx, Web: www.oktetlabs.ru
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/