[PATCH 9/14] random: Remove SA_SAMPLE_RANDOM from i2c drivers

From: Matt Mackall
Date: Fri May 05 2006 - 12:45:23 EST


Remove SA_SAMPLE_RANDOM from i2c drivers

There's no obvious reason why all interrupts from an i2c bus interface
should be considered a good source of the sort of entropy needed by
/dev/random.

Signed-off-by: Matt Mackall <mpm@xxxxxxxxxxx>

Index: 2.6/drivers/i2c/chips/tps65010.c
===================================================================
--- 2.6.orig/drivers/i2c/chips/tps65010.c 2006-05-02 17:28:43.000000000 -0500
+++ 2.6/drivers/i2c/chips/tps65010.c 2006-05-03 13:15:45.000000000 -0500
@@ -521,8 +521,9 @@ tps65010_probe(struct i2c_adapter *bus,
goto fail1;
}

+ irqflags = 0;
#ifdef CONFIG_ARM
- irqflags = SA_SAMPLE_RANDOM | SA_TRIGGER_LOW;
+ irqflags |= SA_TRIGGER_LOW;
if (machine_is_omap_h2()) {
tps->model = TPS65010;
omap_cfg_reg(W4_GPIO58);
@@ -544,8 +545,6 @@ tps65010_probe(struct i2c_adapter *bus,

// FIXME set up this board's IRQ ...
}
-#else
- irqflags = SA_SAMPLE_RANDOM;
#endif

if (tps->irq > 0) {
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/