Re: [PATCH] Bluetooth: fix potential NULL ptr deref indtl1_cs.c::dtl1_hci_send_frame()

From: Marcel Holtmann
Date: Sun May 07 2006 - 15:20:30 EST


Hi Jesper,

> There's a problem in drivers/bluetooth/dtl1_cs.c::dtl1_hci_send_frame()
>
> If bt_skb_alloc() returns NULL, then skb_reserve(s, NSHL); will cause a
> NULL pointer deref - ouch.
> If we can't allocate the resources we require we need to tell the caller
> by returning -ENOMEM.
>
> Found by the coverity checker as bug #409
>
> Patch is compile tested, but that's all, due to lack of hardware.
>
>
> Signed-off-by: Jesper Juhl <jesper.juhl@xxxxxxxxx>

Signed-off-by: Marcel Holtmann <marcel@xxxxxxxxxxxx>

Regards

Marcel


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/