Re: [PATCH] fix can_share_swap_page() when !CONFIG_SWAP

[Nick Piggin]

Hugh Dickins wrote:

> On Mon, 8 May 2006, Nick Piggin wrote:
>
> > Looks like a good patch, nice catch. You should run it past Hugh but tend to
> > agree it would be nice to reuse the out of line can_share_swap_page, which
> > would fold beautifully with PageSwapCache a constant 0.
>
> True; but I think Hua's patch is good as is for now, to fix
> that inefficiency.  I do agree (as you know) that there's scope for
> cleanup there, and that that function is badly named; but I'm still
> unprepared to embark on the cleanup, so let's just get the fix in.

Sure. Queue it up for 2.6.18?
--

Send instant messages to your online friends http://au.messenger.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/