Re: [BUG 2.6.17-git] kmem_cache_create: duplicate cache scsi_cmd_cache

From: Russell King
Date: Fri May 12 2006 - 16:33:55 EST


On Fri, May 12, 2006 at 10:36:57AM -0700, Linus Torvalds wrote:
> Yes. We could just revert that commit, but it seems correct, and I'd
> really like for somebody to understand _why_ that commit matters at all. I
> certainly don't see the overlap here..

Reverting the commit breaks MMC/SD in a very real way, and the fix
is plainly correct and is actually the only possible fix that can be
applied.

It sounds to me like SCSI is relying on some buggy behaviour which is
specific to the way that the kernel works with the fix removed. Maybe
thing is kfree'ing and then reallocating something which remained
registered somewhere when it shouldn't do?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/