Re: 2.6.15-rc1: IDE: fix potential data corruption with SL82C105interfaces

From: Alan Cox
Date: Mon May 15 2006 - 11:12:20 EST


On Llu, 2006-05-15 at 18:32 +0400, Sergei Shtylyov wrote:
> Heh, this driver also tries to cache the single PCI register per-channel
> like hpt366.c... This buglet concerns using fast PIO timings and is probably
> harmless though but needs to be fixed -- I'll send a patch soon...
> I wonder what is otherwise wrong with using 2 channels concurrently?

I've not got any dual channel devices to test, and in fact I couldn't
find anyone with dual channel stuff at all. The caching is one bug, the
fact the reset hits both channels is the other I know about.

Otherwise the libata driver is fairly similar although the timing is
pre-computed from the documentation for the DMA modes.

Alan
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/