Re: 2.6.17-rc4-mm1

From: Andrew Morton
Date: Mon May 15 2006 - 14:08:08 EST


Takashi Iwai <tiwai@xxxxxxx> wrote:
>
> -unsigned int snd_cards_lock = 0; /* locked for registering/using */
> +static unsigned int snd_cards_lock = 0; /* locked for registering/using */

May as well remove the `= 0' while you're there. It adds four bytes to the
module unnecessarily.

> void snd_request_card(int card)
> {
> - int locked;
> -
> if (! current->fs->root)
> return;

I wonder what that's there for.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/