Re: [RFC][PATCH 1/2] Twofish cipher i586-asm optimized

From: Herbert Xu
Date: Tue May 16 2006 - 03:44:42 EST

On Sun, May 07, 2006 at 08:47:46PM +0000, Joachim Fritschi wrote:
> After going over my patch again, i realized i missed the .cra_priority
> and .cra_driver_name setting in the crypto api struct. Here is an updated
> version of my patch:

Thanks for doing this Joachim. I like the result.

But the duplicate key code is a bit too much. The fact that AES does
it should only serve as a reminder for us to fix it, not to create even
more duplication.

So could you please move the key generation code into a separate file,
say crypto/twofish-common.c which can then be shared by all twofish

BTW, please include the actual patches the next time you submit them
along with Signed-off-by lines. You should consult the file
Documentation/SubmittingPatches for detailed instructions.

Visit Openswan at
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page:
PGP Key:
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at