Re: PATCH: Fix broken PIO with libata

From: Jeff Garzik
Date: Tue May 16 2006 - 13:10:16 EST

Tejun Heo wrote:
> Alan Cox wrote:
>> #2 The core sets ATA_DFLAG_PIO to indicate PIO commands should be used
>> on this channel. This same information is available in dev->dma_mode but
>> for some reason we get two sources of the info. The ATA_DFLAG_PIO is set
>> once during setup and then cleared but not re-computed by the revalidate
>> function. This causes DMA commands to be issued when PIO would be and
>> usually an Oops or hang
> Hmmm... I tried to fix this problem in the following commit. With it,
> ATA_DFLAG_PIO isn't cleared over ata_dev_configure(). Only
> ata_dev_set_mode() is allowed to diddle with it and does about the same
> thing as your patch does.

I presume he's looking at what users will hit when 2.6.17 is released...


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at