On Tue, May 16, 2006 at 11:29:34AM -0500, Matt Mackall wrote:-
> On Tue, May 16, 2006 at 06:02:50PM +0200, Adrian Bunk wrote:
> > On Fri, May 12, 2006 at 05:29:52PM -0500, Matt Mackall wrote:
> > >...
> > > --- 2.6.orig/include/linux/ide.h 2006-05-11 15:07:32.000000000 -0500
> > > +++ 2.6/include/linux/ide.h 2006-05-12 14:01:53.000000000 -0500
> > > @@ -252,7 +252,8 @@ static inline void ide_std_init_ports(hw
> > >
> > > #include <asm/ide.h>
> > >
> > > -#ifndef MAX_HWIFS
> > > +#if !defined(MAX_HWIFS) || defined(CONFIG_EMBEDDED)
> > > +#undef MAX_HWIFS
> > > #define MAX_HWIFS CONFIG_IDE_MAX_HWIFS
> > > #endif
> > Why do you need this?
> Doesn't work without it?
> Most platforms define MAX_HWIFS.
OK, now I got it.
Setting this value is sometimes done in heder files and sometimes
done in the Kconfig file.
That is extremely ugly.
Bart, would you accept a patch to set in in the Kconfig file on all
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/