Re: [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups

From: Andrew Morton
Date: Tue May 16 2006 - 15:31:38 EST

Adrian Bunk <bunk@xxxxxxxxx> wrote:
> - remove the following unused EXPORT_SYMBOL's:
> - journal_set_features
> - journal_update_superblock

These might be used by lustre - dunno.

But I'm ducking all patches which alter exports, as usual. If you can get
them through the subsystem maintainer then good luck.

I'd suggest that we pursue the approach of getting the module loader to
spit a warning when someone uses a going-away-soon export.

Arjan had a patch which did that, but he removed basically _every_
presently-unused export. I don't think we should do that. If we're
exporting, for example, the kthread API and we happen to notice that
kthread_bind() isn't presently used by any modules then I don't believe it
makes much sense to unexport kthread_bind(). It makes more sense to export
the kthread API as a whole.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at