Re: [RFC: 2.6 patch] fs/jbd/journal.c: possible cleanups

From: Andrew Morton
Date: Tue May 16 2006 - 15:50:46 EST


Adrian Bunk <bunk@xxxxxxxxx> wrote:
>
> On Tue, May 16, 2006 at 12:27:31PM -0700, Andrew Morton wrote:
> > Adrian Bunk <bunk@xxxxxxxxx> wrote:
> > >
> > > - remove the following unused EXPORT_SYMBOL's:
> > > - journal_set_features
> > > - journal_update_superblock
> >
> > These might be used by lustre - dunno.
>
> I don't see this.

Lustre doesn't use these?

Still, the jbd API is exported for other filesystems to use. If these
functions are considered part of that API (they are) then I'd suggest that
they should be exported.

> > But I'm ducking all patches which alter exports, as usual. If you can get
> > them through the subsystem maintainer then good luck.
> >...
>
> Since you replied to this patch:
> Who is the subsystem maintainer for jbd?

A few people, including me..
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/