Re: [PATCH] fix race in inotify_release

From: John McCutchan
Date: Tue May 16 2006 - 15:53:58 EST

On Tue, 2006-05-16 at 15:39 -0400, Amy Griffis wrote:
> While doing some inotify stress testing, I hit the following race. In
> inotify_release(), it's possible for a watch to be removed from the
> lists in between dropping dev->mutex and taking inode->inotify_mutex.
> The reference we hold prevents the watch from being freed, but not
> from being removed.
> Checking the dev's idr mapping will prevent a double list_del of the
> same watch.

Looks good. Thanks for the patch and stress testing inotify!

John McCutchan <john@xxxxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at