Re: libata PATA updated patch

[Matthieu CASTET]

Le Tue, 16 May 2006 17:13:57 +0100, Alan Cox a écrit :

> I've put a patch versus -rc4 in the usual place. This should sort out
> the PIO problems and a few other glitches
> 
> Alan
> 
> http://zeniv.linux.org.uk/~alan/IDE
Ok the via timing are ok now.

If I had in ata_host_intr someting like [1] for checking the altstatus, my
ATAPI drive works.
It report "ata_altstatus take 3us", for driver that wasn't worked before.

I don't know if it is a correct fix and where it should be putted (in
libata-core or in the pata_via check_altstatus callback).
I don't know if it should be used only for ATA_CMD_SET_FEATURES &&
SETFEATURES_XFER.

Now real testing could begging.

Matthieu



[1]
		for (i=0; ata_altstatus(ap) & ATA_BUSY; i++) {
                        if (i > 10)
                                goto idle_irq;
                udelay(1);
                }
                if (i)
                        printk("ata_altstatus take %dus\n", i);

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/