Re: [PATCH] swap-prefetch, fix lru_cache_add_tail()

From: Con Kolivas
Date: Thu May 18 2006 - 02:39:50 EST


On Thursday 18 May 2006 02:54, Peter Zijlstra wrote:
> From: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>
>
> lru_cache_add_tail() uses the inactive per-cpu pagevec. This causes
> normal inactive and intactive tail inserts to end up on the wrong end
> of the list.
>
> When the pagevec is completed by lru_cache_add_tail() but still contains
> normal inactive pages, all pages will be added to the inactive tail and
> vice versa.
>
> Also *add_drain*() will always complete to the inactive head.
>
> Add a third per-cpu pagevec to alleviate this problem.

Thanks!

> Signed-off-by: Peter Zijlstra <a.p.zijlstra@xxxxxxxxx>

Signed-off-by: Con Kolivas <kernel@xxxxxxxxxxx>

--
-ck
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/