Re: [openib-general] Re: [PATCH 35 of 53] ipath - some interrelatedstability and cleanliness fixes

From: Dave Olson
Date: Thu May 18 2006 - 03:03:56 EST


On Wed, 17 May 2006, Roland Dreier wrote:
| I do see obvious bugs in ipath_user_pages.c, though. In
| ipath_release_user_pages_on_close(), you have:
|
| mm = get_task_mm(current);
| if (!mm)
| goto bail;

It turns out that since this is called from ipath_close(),
mm will always be NULL, so what we do is leak memory, and
possibly leave some locked pages. I've been looking at this
code this evening; fixing it is clearly needed, but doesn't help
the long delays, hangs, and watchdogs, so far.

Dave Olson
olson@xxxxxxxxxxxx
http://www.unixfolk.com/dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/