Re: [PATCH/2.6.17-rc4 10/10] bugs fix for marvell SATA on powerpc pl atform

From: Jeff Garzik
Date: Thu May 18 2006 - 17:07:01 EST

Mark Lord wrote:
Jeff Garzik wrote:
Benjamin Herrenschmidt wrote:
On Thu, 2006-05-18 at 12:03 +0800, Zang Roy-r61911 wrote:
@@ -1567,13 +1570,18 @@ static void mv5_read_preamp(struct mv_ho
static void mv5_enable_leds(struct mv_host_priv *hpriv, void __iomem
u32 tmp;
+#ifndef CONFIG_PPC
writel(0, mmio + MV_GPIO_PORT_CTL);

You'll have to do better here too... I don't wee why when compiled on
PPC, this driver should "magically" not clear those bits... At the very
least, you should test the machine type if you want to do something
specific to your platform, but first, you'll have to convince Jeff why
this change has to be done in the first place and if there is a better
way to handle it.

Correct... it does seem some bugs were found, but #ifdef powerpc is certainly out of the question. We want the driver to work without ifdefs on all platforms.

Yup. I have a powerpc platform here with PCI-X, and a PCI-X Marvell card
to try in it. So I'll pick up these changes and try to integrate them a
little more nicely in my internal updated driver, and then pass it on to

When will this happen? I'm getting worried that useful stuff is disappearing into the Mark Lord ether, with no changes appearing on the other side. Haven't seen patches from you in weeks.

I'm happy that you have an updated internal driver, but that helps no one else.


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at