Re: [PATCH] rtc subsystem, use ENOIOCTLCMD where appropriate

From: H. Peter Anvin
Date: Thu May 18 2006 - 18:38:10 EST

Ingo Oeser wrote:
Hi Hans Peter,

H. Peter Anvin wrote
ENOIOCTLCMD is right here, *except* in the very last hunk, because
it's a request to the upper layers to emulate the operation:

So would a patch like this be welcome and clear this up?

diff --git a/include/linux/errno.h b/include/linux/errno.h
index d90b80f..d33ae4b 100644
--- a/include/linux/errno.h
+++ b/include/linux/errno.h
@@ -9,7 +9,7 @@
#define ERESTARTSYS 512
#define ERESTARTNOHAND 514 /* restart if no handler.. */
-#define ENOIOCTLCMD 515 /* No ioctl command */
+#define ENOIOCTLCMD 515 /* No ioctl command, upper layer please emulate or pass ENOTTY to user space */
#define ERESTART_RESTARTBLOCK 516 /* restart by calling sys_restart_syscall */
/* Defined for the NFSv3 protocol */

Sure, if people feel it's necessary.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at