Re: [PATCH 02/11] atyfb_base compile fix for CONFIG_PCI=n

From: Andrew Morton
Date: Wed May 24 2006 - 21:33:11 EST


zippel@xxxxxxxxxxxxxx wrote:
>
> The atyfb_driver structure is only available if CONFIG_PCI is set.
>
> Signed-off-by: Roman Zippel <zippel@xxxxxxxxxxxxxx>
>
> ---
>
> drivers/video/aty/atyfb_base.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> Index: linux-2.6-mm/drivers/video/aty/atyfb_base.c
> ===================================================================
> --- linux-2.6-mm.orig/drivers/video/aty/atyfb_base.c
> +++ linux-2.6-mm/drivers/video/aty/atyfb_base.c
> @@ -3861,7 +3861,9 @@ static int __init atyfb_init(void)
> atyfb_setup(option);
> #endif
>
> +#ifdef CONFIG_PCI
> pci_register_driver(&atyfb_driver);
> +#endif
> #ifdef CONFIG_ATARI
> atyfb_atari_probe();
> #endif
> @@ -3870,7 +3872,9 @@ static int __init atyfb_init(void)
>
> static void __exit atyfb_exit(void)
> {
> +#ifdef CONFIG_PCI
> pci_unregister_driver(&atyfb_driver);
> +#endif
> }

bah. If pci_register_driver() was a macro we wouldn't need to do this all
over the place.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/