Re: [PATCH -rt 2/2] Fix condition in default_idle

From: Ingo Molnar
Date: Fri May 26 2006 - 13:39:00 EST



* Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> The condition statement in default_idle had the conjunctions
> backwards. Instead of && it had || so the idle thread would never be
> preempted.

> - while (!need_resched() || !need_resched_delayed()) {
> + while (!need_resched() && !need_resched_delayed()) {
> local_irq_disable();
> - if (!need_resched() || !need_resched_delayed())
> + if (!need_resched() && !need_resched_delayed())

doh! Good catch - applied.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/