Re: [PATCH] HPT3xx: switch to using pci_get_slot()

[Sergei Shtylyov]

Hello.

Jiri Slaby wrote:

> >   Switch to using pci_get_slot() to get to the function 1 of HPT36x/374
> > chips -- there's no need for the driver itself to walk the list of the
> > PCI devices, and it also forgets to check the bus number of the device
> > found.

> It's better, but you missed to call pci_dev_put() in some __exit function.

   If you knew the PCI IDE drivers better, you'd know there's simply no 
__exit functions in them. ;-)

WBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/