Re: [patch 61/61] lock validator: enable lock validator in Kconfig

[Roman Zippel]

Hi,

On Mon, 29 May 2006, Ingo Molnar wrote:

> Index: linux/lib/Kconfig.debug
> ===================================================================
> --- linux.orig/lib/Kconfig.debug
> +++ linux/lib/Kconfig.debug
> @@ -184,6 +184,173 @@ config DEBUG_SPINLOCK
>  	  best used in conjunction with the NMI watchdog so that spinlock
>  	  deadlocks are also debuggable.
>  
> +config PROVE_SPIN_LOCKING
> +	bool "Prove spin-locking correctness"
> +	default y

Could you please keep all the defaults in a separate -mm-only patch, so 
it doesn't get merged?
There are also a number of dependencies on DEBUG_KERNEL missing, it 
completely breaks the debugging menu.

> +config LOCKDEP
> +	bool
> +	default y
> +	depends on PROVE_SPIN_LOCKING || PROVE_RW_LOCKING || PROVE_MUTEX_LOCKING || PROVE_RWSEM_LOCKING

This can be written shorter as:

config LOCKDEP
	def_bool PROVE_SPIN_LOCKING || PROVE_RW_LOCKING || PROVE_MUTEX_LOCKING || PROVE_RWSEM_LOCKING

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/