Re: usb-serial ipaq kernel problem

From: Pete Zaitcev
Date: Tue May 30 2006 - 14:34:12 EST


On Tue, 30 May 2006 19:48:21 +0200, Frank Gevaerts <frank.gevaerts@xxxxxx> wrote:
+0100
> +++ linux-2.6.17-rc4.test/drivers/usb/serial/ipaq.c 2006-05-30 19:41:19.000000000 +0200
> @@ -692,6 +694,7 @@ static void ipaq_close(struct usb_serial
> struct ipaq_private *priv = usb_get_serial_port_data(port);
>
> dbg("%s - port %d", __FUNCTION__, port->number);
> +
>
> /*
> * shut down bulk read and write

Please get rid of the above.

> @@ -967,3 +971,6 @@ MODULE_PARM_DESC(vendor, "User specified
>
> module_param(product, ushort, 0);
> MODULE_PARM_DESC(product, "User specified USB idProduct");
> +
> +module_param(connect_retries, int, KP_RETRIES);
> +MODULE_PARM_DESC(product, "Maximum number of connect retries (100ms each)");

Personally, I'm not keen on adding knobs.

-- Pete
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/