Re: [PATCH 7/11] 2.6.17-rc5 perfmon2 patch for review: modified i386files

[Roman Zippel]

Hi,

On Thu, 1 Jun 2006, Stephane Eranian wrote:

> > > +config PERFMON
> > > +  	bool "Perfmon2 performance monitoring interface"
> > > +	select X86_LOCAL_APIC
> > > +	default y
> > 
> > Drop the defaults and I'm pretty sure you don't want to use select.
> > 
> What's wrong with 'default y' ?

Why should it be enabled by default?

> Are you suggesting I use 'depends' instead of select?

That's one possibility. Why did you select in the first place?

bye, Roman
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/