Re: input: fix comments and blank lines in new ff code

[Randy.Dunlap]

On Thu, 1 Jun 2006 23:47:16 +0300 Anssi Hannula wrote:

> From: Anssi Hannula <anssi.hannula@xxxxxxxxx>
> 
> Fix comments so that they conform to kernel-doc or remove ** if they are
> not in kernel-doc format.
> Akso add/remove some blank lines.
> 
> Signed-off-by: Anssi Hannula <anssi.hannula@xxxxxxxxx>
> ---
> 
> Note that the From header of my email is different as otherwise
> osdl.org would mark my email as spam. Please use my gmail.com address.

What's up with that?  OSDL filters are overly strong?


> Index: linux-2.6.17-rc4-git12/drivers/usb/input/hid-pidff.c
> ===================================================================
> --- linux-2.6.17-rc4-git12.orig/drivers/usb/input/hid-pidff.c	2006-06-01 18:51:39.000000000 +0300
> +++ linux-2.6.17-rc4-git12/drivers/usb/input/hid-pidff.c	2006-06-01 23:24:47.000000000 +0300
> @@ -914,16 +925,17 @@ static int pidff_reports_ok(struct input
>  	return 1;
>  }
>  
> -/**
> - * Find a field with a specific usage within a report
> - * @report: The report from where to find
> - * @usage: The wanted usage
> +/*
> + * pidff_find_logical_field - find a field with a specific logical usage
> + * @report: the report from where to find
> + * @usage: the wanted usage
>   * @enforce_min: logical_minimum should be 1, otherwise return NULL
>   */

Comment does not match function name.

>  static struct hid_field *pidff_find_special_field(struct hid_report *report,
>  						  int usage, int enforce_min)
>  {
>  	int i;
> +
>  	for (i = 0; i < report->maxfield; i++) {
>  		if (report->field[i]->logical == (HID_UP_PID | usage)
>  		    && report->field[i]->report_count > 0) {


And I noticed one function name _input_ff_erase().
That might be a namespace violation... anyone know the namespace
rules?

Otherwise all looks good to me.

---
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/