Re: State of resume for AHCI?

[Jens Axboe]

On Fri, Jun 02 2006, zhao, forrest wrote:
> On Fri, 2006-06-02 at 08:43 +0200, Hannes Reinecke wrote:
> > Jens Axboe wrote:
> > > On Fri, Jun 02 2006, zhao, forrest wrote:
> > >> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> > >>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> > >>>> Jens Axboe wrote:
> > >>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
> > >>>>> have the resume/suspend methods defined, plus it needs more work than
> > >>>>> piix on resume.
> > >>>>>  
> > >>>> Hannes Reinecke's patch implements those functions, basically by 
> > >>>> factoring out the shutdown and init code and calling them at 
> > >>>> suspend/resume time as well.
> > >>>>
> > >>>> Is that correct/sufficient?  Or should something else be happening?
> > >>> No that's it, I know for a fact that suspend/resume works perfectly with
> > >>> the 10.1 suse kernel. You can give that a shot, if you want.
> > >> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
> > >> posted in open source community(or in linux-ide mailing list) didn't
> > >> work.
> > > 
> > > I didn't say Hannes patch, I said I know that 10.1 works. And that is
> > > probably in large due to the patch that Hannes did, which implents
> > > resume/suspend and takes care of reinitializing the resources.
> > > 
> > Indeed. I didn't post the latest set of patches to the open-source
> > community as Jeff indicated he would only accept patches against
> > libata-dev. And as I didn't have time to port them yet I didn't feel the
> > need to do so.
> > 
> > Forrest, please drop me a mail if I can be of further assistance.
> 
> I almost finished porting a patch from OpenSUSE, will send it out in an
> hour, please help review it :)

Wonderful! Please do test it as well :-)

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/