Re: 2.6.17-rc5-mm3

[Valdis . Kletnieks]

On Sun, 04 Jun 2006 12:41:21 +0200, Ingo Molnar said:

> could you please apply the following patches ontop of -mm3:
> 
>   http://redhat.com/~mingo/lockdep-patches/lockdep-combo-2.6.17-rc5-mm3.patch
>   http://redhat.com/~mingo/lockdep-patches/lockdep-tracer-2.6.17-rc5-mm3.patch

Just for grins, I tried building this, and got this error:

  CC      kernel/irq/handle.o
kernel/irq/handle.c:246:35: error: macro "early_init_irq_lock_type" passed 1 arguments, but takes just 0
kernel/irq/handle.c:247: error: expected '=', ',', ';', 'asm' or '__attribute__' before '{' token
make[2]: *** [kernel/irq/handle.o] Error 1

It won't build if you don't have CONFIG_TRACE_IRQFLAGS defined - and that
is defined like this:

config TRACE_IRQFLAGS
        bool
        default y
        depends on TRACE_IRQFLAGS_SUPPORT
        depends on PROVE_SPIN_LOCKING || PROVE_RW_LOCKING

but my config has:
% grep PROVE .config
# CONFIG_PROVE_SPIN_LOCKING is not set
# CONFIG_PROVE_RW_LOCKING is not set
# CONFIG_PROVE_MUTEX_LOCKING is not set
# CONFIG_PROVE_RWSEM_LOCKING is not set

So using the defaults for the PROVE_* won't compile clean.  Yes, probably
a stupid setting for anybody applying the patches, but.. ;)

(I'm off to go build kernels without the patch, and with the PROVE_* set)..

Attachment: pgp00000.pgp
Description: PGP signature