[PATCH 7/9] PCI PM: handle PMCSR more carefully

[Adam Belay]

This patch changes __pci_set_power_state() such that it only modifies
the power state byte in PMCSR.   Otherwise a PME event might
accidentally be cleared (when entering a state greater than D0), or
PME_En might be cleared (when returning to D0) despite the device driver
intending to leave it enabled in D0.

Signed-off-by: Adam Belay <abelay@xxxxxxxxxx>

---
 pm.c |   16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff -urN a/drivers/pci/pm.c b/drivers/pci/pm.c
--- a/drivers/pci/pm.c	2006-06-04 02:41:21.000000000 -0400
+++ b/drivers/pci/pm.c	2006-06-04 03:39:20.000000000 -0400
@@ -114,23 +114,9 @@
 static void __pci_set_power_state(struct pci_dev *dev, pci_power_t state)
 {
 	struct pci_dev_pm *pm = dev->pm;
-	u16 pmcsr;
-
-	pci_read_config_word(dev, pm->pm_offset + PCI_PM_CTRL, &pmcsr);
-
-	/* If we're (effectively) in D3, force entire word to 0.
-	 * This doesn't affect PME_Status, disables PME_En, and
-	 * sets PowerState to 0.
-	 */
-	if (dev->current_state == PCI_D3) {
-		pmcsr = 0;
-	} else {
-		pmcsr &= ~PCI_PM_CTRL_STATE_MASK;
-		pmcsr |= state;
-	}
 
 	/* enter specified state */
-	pci_write_config_word(dev, pm->pm_offset + PCI_PM_CTRL, pmcsr);
+	pci_write_config_byte(dev, pm->pm_offset + PCI_PM_CTRL, state);
 
 	/* Mandatory power management transition delays */
 	/* see PCI PM 1.1 5.6.1 table 18 */


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/