Re: pci_restore_state

From: Adam Belay
Date: Mon Jun 05 2006 - 14:28:23 EST


On Sun, Jun 04, 2006 at 09:20:24PM +1000, Paul Mackerras wrote:
> Andrew Morton writes:
>
> > On Sun, 04 Jun 2006 06:13:30 -0400
> > Ryan Lortie <desrt@xxxxxxxx> wrote:
> > > If I reverse the for loop to start from 15 and count down to 0, then the
> > > majority of the configuration space is filled in _before_ the command
> > > word is modified. No crash.
> >
> > We have a patch pending which will do that.
> >
> > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/gregkh-03-pci/pci-reverse-pci-config-space-restore-order.patch
>
> We really shouldn't be writing to the BIST register, at least...
>
> Also, I don't quite see the point of writing to the read-only
> registers such as vendor and device ID.
>
> Paul.

Any comments on this patch as an alternative solution?

http://marc.theaimsgroup.com/?l=linux-kernel&m=114949711413176&w=2

Thanks,
Adam
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/