Re: [patch] i386: print NUMA in oops messages

[Andrew Morton]

On Mon, 5 Jun 2006 23:01:14 -0400
Chuck Ebbert <76306.1226@xxxxxxxxxxxxxx> wrote:

> +		printk(
>  #ifdef CONFIG_PREEMPT
> -		printk("PREEMPT ");
> +			"PREEMPT "
>  #endif
>  #ifdef CONFIG_SMP
> -		printk("SMP ");
> +			"SMP "
> +#endif
> +#ifdef CONFIG_NUMA
> +			"NUMA "
>  #endif
>  #ifdef CONFIG_DEBUG_PAGEALLOC
> -		printk("DEBUG_PAGEALLOC");
> +			"DEBUG_PAGEALLOC"
>  #endif
> -		printk("\n");
> +			"\n");
> +

This is too cute for my taste.  Keep it simple.

I suppose one could do something like

static const char config_string[] = ""
#ifdef CONFIG_SMP
	" SMP"
#endif
#ifdef CONFIG_NUMA
	" NUMA"
#endif
;

if one really feels so motivated...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/