Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Krzysztof Halasa]

Paul Fulghum <paulkf@xxxxxxxxxxxxx> writes:

> +++ b/drivers/net/wan/Makefile	2006-06-06 14:08:53.000000000 -0500
> @@ -9,14 +9,18 @@ cyclomx-y                       := cycx_
>  cyclomx-$(CONFIG_CYCLOMX_X25)	+= cycx_x25.o
>  cyclomx-objs			:= $(cyclomx-y)  
>  
> -hdlc-y				:= hdlc_generic.o
> +hdlc-$(CONFIG_HDLC)		:= hdlc_generic.o
>  hdlc-$(CONFIG_HDLC_RAW)		+= hdlc_raw.o
>  hdlc-$(CONFIG_HDLC_RAW_ETH)	+= hdlc_raw_eth.o
>  hdlc-$(CONFIG_HDLC_CISCO)	+= hdlc_cisco.o
>  hdlc-$(CONFIG_HDLC_FR)		+= hdlc_fr.o
>  hdlc-$(CONFIG_HDLC_PPP)		+= hdlc_ppp.o
>  hdlc-$(CONFIG_HDLC_X25)		+= hdlc_x25.o
> -hdlc-objs			:= $(hdlc-y)
> +ifeq ($(CONFIG_HDLC),y)
> +  hdlc-objs			:= $(hdlc-y)
> +else
> +  hdlc-objs			:= $(hdlc-m)
> +endif

How could that work? If CONFIG_HDLC=m and CONFIG_HDLC_*=y it would read:

hdlc-m := hdlc_generic.o
hdlc-y := hdlc_{raw,raw_eth,cisco,fr,ppp,x25}.o
hdlc-objs := $(hdlc-m)

CONFIG_HDLC is 3-state and CONFIG_HDLC_* are simple bools, everything
makes a single module.

Not sure what missing symbols do you experience (never had synclink
adapter) but almost certainly it's when generic HDLC is not selected
(or is 'm' while synclink is 'y') and it's not related to the Makefile
(i.e., while I don't exactly like the rest of the patch as I think
enabling gHDLC should enable hw drivers - like with other drivers -
it would probably work).
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/