Re: [PATCH -mm] misroute-irq: Don't call desc->chip->end because of edge interrupts

From: Ingo Molnar
Date: Tue Jun 06 2006 - 17:50:09 EST



* Andrew Morton <akpm@xxxxxxxx> wrote:

> On Tue, 06 Jun 2006 06:50:19 -0400
> Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
>
> > On Tue, 2006-06-06 at 10:01 +0200, Ingo Molnar wrote:
> > > * Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:
> > >
> > > > Hit the following BUG with irqpoll. The below patch fixes it.
> > >
> > > > - if (work)
> > > > + if (work && disc->chip && desc->chip->end)
> > > > desc->chip->end(i);
> > >
>
> Why is this change necessary? 2.6.17-rc6 doesn't have it, and it
> doesn't oops. So somebody changed something. What? Why? Was it
> intentional? Was it correct?

that's due to the irqchips change on x86 and x86_64. So it's not
something in -rc6 or some other unknown effect.

Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/