Re: [PATCH] fix missing hdlc symbols for synclink drivers

[Krzysztof Halasa]

Paul Fulghum <paulkf@xxxxxxxxxxxxx> writes:

> There is nothing random about these select statements.
> They are chosen specifically to fix the dependencies.

And they may work until someone changes something - like a CONFIG_*
name or directory structure.

> You may feel they are ugly, but 'select' is the only tool
> I know of that fixes these errors without losing flexibility.

I don't know what special flexibility are you thinking about.
DEPENDing on a symbol is as flexible and causes no such problems.
The user just needs to enable (in this case) WAN and HDLC
manually ((s)he has to select HDLC_* manually anyway). It could
even make SYNCLINK_*_HDLC unneeded, the added functionality could
(optionally) be selected automagically.

SELECTs are maybe good for small things but such inter-directory
ones are IMHO asking for trouble.
-- 
Krzysztof Halasa
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/