Re: [NFS] [PATCH] NFS server does not update mtime on setattr request

From: J. Bruce Fields
Date: Wed Jun 07 2006 - 11:19:02 EST


On Wed, Jun 07, 2006 at 10:44:50AM -0400, Peter Staubach wrote:
> I saw that wording too and assumed what I think that you assumed. I
> assumed that that meant that if the new size is equal to the old size,
> then nothing should be changed. However, that does not seem to be how
> those words are to be interpreted. They are to be interpreted as "if
> the new length of the file can be successfully set, then the
> mtime/ctime should be changed".

What's the basis for that interpretation? The language seems extremely
clear:

"On successful completion, if the file size is changed, these
functions will mark for update the st_ctime and st_mtime fields
of the file, and if the file is a regular file, the S_ISUID and
S_ISGID bits of the file mode may be cleared."

Why are you concerned about this? Do you have an actual application
that breaks?

--b.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/