Re: [uml-devel] [PATCH 2/8] UML - Define jmpbuf access constants

From: Blaisorblade
Date: Wed Jun 07 2006 - 13:32:58 EST


On Monday 05 June 2006 17:40, Jeff Dike wrote:
> On Sun, Jun 04, 2006 at 08:19:59PM +0200, Blaisorblade wrote:
> > What about #ifdef'ing out the offending code #ifndef one of these
> > constants (they'll be defined or not altogether). As expectable, this
> > wasn't yet implemented - let's give the right priority to things.
> > (I've just met this on my SuSE, btw, which prompted me to write this
> > email).
>
> I think hpa just came to our rescue. There's a setjmp/longjmp
> implementation in klibc. If we pull that in and use it, we don't need
> our own copy.

Ok - but we can merge something before 2.6.17, and we should. Any of them.
Guess which one...

Not merging hacks is sometimes ok, and guarantees better code. But we're
exceeding in this :-)
--
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale!
http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/