Re: [Patch] sched: mc/smt power savings sched policy

[Siddha, Suresh B]

On Wed, Jun 07, 2006 at 09:49:43AM -0700, Andrew Morton wrote:
> On Tue, 6 Jun 2006 11:25:21 -0700
> "Siddha, Suresh B" <suresh.b.siddha@xxxxxxxxx> wrote:
> 
> > Appended the patch. Can someone please test compile the powerpc change?
> 
> powerpc compiles and boots OK, but sparc64 is not so good.
> 
> kernel/built-in.o(.text+0x6ec0): In function `sched_create_sysfs_power_savings_entries':
> : undefined reference to `smt_capable'

Dave, I am not sure if the appended patch is the correct(perhaps temporary?)
mechanism(currently smp_prepare_cpus() also uses this mechanism) in identifying
a SMT capable sparc64 processor. Can you confirm?

thanks,
suresh
--

Signed-off-by: Suresh Siddha <suresh.b.siddha@xxxxxxxxx>

--- linux-2.6.17-rc5/include/asm-sparc64/topology.h	2006-05-24 18:50:17.000000000 -0700
+++ linux/include/asm-sparc64/topology.h	2006-06-07 08:28:13.726071744 -0700
@@ -1,6 +1,9 @@
 #ifndef _ASM_SPARC64_TOPOLOGY_H
 #define _ASM_SPARC64_TOPOLOGY_H
 
+#include <asm/spitfire.h>
+#define smt_capable()	(tlb_type == hypervisor)
+
 #include <asm-generic/topology.h>
 
 #endif /* _ASM_SPARC64_TOPOLOGY_H */
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/